✨ change metrics default to off #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
cc: @JoelSpeed |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
The bot somehow didn't add the lgtm label :/ |
mengqiy
added
the
lgtm
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
…y_default ✨ change metrics default to off
6 tasks
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Running End-to-end Tests on Remote Clusters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR flips the default of the unreleased metrics feature.
The reason is that we spin up a controller-manager in each of our controller's unit test, e.g. https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/project/pkg/controller/firstmate/firstmate_controller_test.go
When there are multiple controllers in the same project, they will race for binding to the same default port which will cause some of them failing.
The plan is that in v0.1 branch we leave it off by default and in v0.2 release (happening very soon) we flip the default to on.