Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix reconcile duration metric #248

Merged
merged 1 commit into from
Dec 12, 2018
Merged

🐛 Fix reconcile duration metric #248

merged 1 commit into from
Dec 12, 2018

Conversation

j-vizcaino
Copy link
Contributor

The previous implementation lacked delayed execution, leading to
end - now not reflecting the duration of the reconcile request handling.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 12, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2018
The previous implementation lacked delayed execution, leading to
end - now not reflecting the duration of the reconcile request handling.
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the PR.

@droot
Copy link
Contributor

droot commented Dec 12, 2018

@j-vizcaino you will need to sign the CLA

@droot droot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2018
@j-vizcaino
Copy link
Contributor Author

j-vizcaino commented Dec 12, 2018 via email

@j-vizcaino
Copy link
Contributor Author

Signed the CLA. This should be good now.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 12, 2018
@droot droot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: j-vizcaino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 40894d1 into kubernetes-sigs:master Dec 12, 2018
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
Link project deps from hack/imports.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants