Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix nil error when using BootstrapOptions.Host #272

Merged
merged 1 commit into from
Jan 7, 2019
Merged

🐛 fix nil error when using BootstrapOptions.Host #272

merged 1 commit into from
Jan 7, 2019

Conversation

ichekrygin
Copy link
Contributor

Fixes: #271

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 1, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 1, 2019
@ichekrygin
Copy link
Contributor Author

/assign @DirectXMan12

@ichekrygin
Copy link
Contributor Author

/test

@DirectXMan12
Copy link
Contributor

looks good. can you squash the commits together. (also /test won't work b/c we're not running PRs via prow yet :-/)

@ichekrygin
Copy link
Contributor Author

@DirectXMan12 - rebase is done.
It appears that "Linux" build failing (intermittent?).
Is there a way to re-run the build?

@DirectXMan12
Copy link
Contributor

I can do it. Let me file a bug too. I've got an issue to switch to prow now (#276) so that I don't have to do it.

@DirectXMan12
Copy link
Contributor

filed a bug for the test flake too (#277)

@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, ichekrygin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2019
@DirectXMan12
Copy link
Contributor

/hold
wait a moment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2019
DirectXMan12
DirectXMan12 suggested changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@DirectXMan12 DirectXMan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment inline

pkg/webhook/bootstrap.go Outdated
@@ -297,7 +297,7 @@ func (s *Server) validatingWHConfigs() (runtime.Object, error) {
}

func (s *Server) admissionWebhook(path string, wh *admission.Webhook) (*admissionregistration.Webhook, error) {
if wh.NamespaceSelector == nil && len(s.Service.Namespace) > 0 {
if wh.NamespaceSelector == nil && (s.Service == nil || s.Service.Namespace == "") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you want the opposite here? This seems to change the meaning

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah.. right. fixing...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DirectXMan12 this should be fixed, PTAL.

@ichekrygin
Fix nil error when using BootstrapOptions.Host
01f78d9 
Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2019
@mengqiy
Copy link
Member

mengqiy commented Jan 7, 2019

/lgtm
/hold cancel
Thanks for catching this and fixing this.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 60b09a8 into kubernetes-sigs:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 DirectXMan12 requested changes

@droot droot Awaiting requested review from droot

Assignees

@DirectXMan12 DirectXMan12

@mengqiy mengqiy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ichekrygin @DirectXMan12 @k8s-ci-robot @mengqiy