⚠️ Convert client.List to use functional options #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
approved
|
@grantr would be great if you can take a quick look. |
pkg/client/interfaces.go
Outdated
| // cl.List(ctx, list, client.UseListOptions(lo.InNamespace(ns).MatchingLabels(labels))) | ||
| func UseListOptions(newOpts *ListOptions) ListOptionFunc { | ||
| return func(opts *ListOptions) { | ||
| opts.LabelSelector = newOpts.LabelSelector |
There was a problem hiding this comment.
can this just be *opts = *newOpts?
Replaces:
List(ctx, ListOptions, list)
with:
List(ctx, list, ...option)
This matches the upcoming functional options signature of client.Delete.
To use the previous builder options, use the UseListOptions functional
option:
lo := &client.ListOptions{}
client.List(ctx, list, client.UseListOptions(
lo.InNamespace(ns).MatchingLabels(labels)
))
Ported kubernetes-sigs#106 PR
|
/lgtm |
k8s-ci-robot
added
the
lgtm
grantr
approved these changes
Jan 16, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, droot, grantr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces:
List(ctx, ListOptions, list)with:
List(ctx, list, ...Option)This matches the functional options signature of
client.Deletein #94.A few examples (I tried formatting these as a table but it wasn't wide enough):
Select all:
Filter by namespace:
Filter by namespace and labels:
To assemble a
ListOptionswith the builder methods or some other strategy, use theUseListOptionsfunctional option:Note: This PR was contributed by @grantr but we couldn't get it merged because of the breaking changes, but now we are ready for a major revision
0.2.0, so I manually ported #106