Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Squash some remaining references to runtime/log #334

Merged
merged 1 commit into from
Feb 27, 2019
Merged

🐛 Squash some remaining references to runtime/log #334

merged 1 commit into from
Feb 27, 2019

Conversation

DirectXMan12
Copy link
Contributor

This squashes some remaining references to runtime/log, which would have
forced pulling in Zap.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2019
@DirectXMan12 DirectXMan12 force-pushed the refactor/squash-runtime-log-references branch from 57e9072 to 017711e Compare February 27, 2019 00:52
@droot droot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2019
@DirectXMan12
Squash some remaining references to runtime/log
9ff5157 
This squashes some remaining references to runtime/log, which would have
forced pulling in Zap.
@DirectXMan12 DirectXMan12 force-pushed the refactor/squash-runtime-log-references branch from 017711e to 9ff5157 Compare February 27, 2019 21:49
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2019
@DirectXMan12 DirectXMan12 added this to the 0.2.0 milestone Feb 27, 2019
@mengqiy
Copy link
Member

mengqiy commented Feb 27, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 89c373a into kubernetes-sigs:master Feb 27, 2019
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
@k8s-ci-robot
Merge pull request #334 from superbrothers/fix-typo
b1242ed 
Fix typo for "Controller"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@mengqiy mengqiy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DirectXMan12 @k8s-ci-robot @mengqiy @droot