New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent header for generated files with other k8s code generation tools #300
Comments
If this makes sense, please let me know. I'd love to send a PR. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The header for other k8s code generation tools, such as
defaulter-gen
,deepcopy-gen
andconversion-gen
looks like:But our header is different:
This may break something. For example,
verify-boilerplate.sh
in k/k usesDO NOT EDIT
as a key word to identify automatically generated files. Ref: https://github.com/kubernetes/kubernetes/blob/master/hack/boilerplate/boilerplate.py#L211So we'd better keep the header consistent with other code generation tools for a more consistent experience.
The text was updated successfully, but these errors were encountered: