✨Add flags to customize API path and contexts #144
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
If I'm way out of left field with this, I am totally open to course corrections. I'm still figuring this tool out totally |
damemi
force-pushed
the
vendor-pkg
branch
3 times, most recently
from
38b5027
to
91f29b6
Compare
k8s-ci-robot
added
size/M
damemi
force-pushed
the
vendor-pkg
branch
3 times, most recently
from
6cebeec
to
db77456
Compare
|
@droot @DirectXMan12 I've updated this PR, could either of you please take another look at this? |
|
bump, any more feedback on this? |
pkg/crd/generator/generator.go
Outdated
| @@ -112,7 +109,7 @@ func (c *Generator) Do() error { | |||
| return fmt.Errorf("failed switching working dir: %v", err) | |||
| } | |||
|
|
|||
| if err := b.AddDirRecursive("./pkg/apis"); err != nil { | |||
| if err := b.AddDirRecursive(fmt.Sprintf("./%s", c.APIsPath)); err != nil { | |||
There was a problem hiding this comment.
If this is always relative, then we should update the help text for api-path commandline param to reflect that.
I wish filepath.Join(".", c.APIsPath) worked for this case, but looks like doesn't.
nit: probably "./" + c.APIsPath reads better in this case.
pkg/crd/generator/generator.go
Outdated
| @@ -112,7 +109,7 @@ func (c *Generator) Do() error { | |||
| return fmt.Errorf("failed switching working dir: %v", err) | |||
| } | |||
|
|
|||
| if err := b.AddDirRecursive("./pkg/apis"); err != nil { | |||
| if err := b.AddDirRecursive("./%s" + c.APIsPath); err != nil { | |||
There was a problem hiding this comment.
"path/filepath".Join is probably safer here.
There was a problem hiding this comment.
that drops the leading ./ :(
droot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
droot
added
the
lgtm
We have some use cases where API types are defined in a different package or location than the default
pkg/apiscurrently hardcoded. For example, we have vendored types in an API library that correspond to CRDs in multiple different repos; this would allow us to establish a workflow such asvendor/org/library/some-api/v1/)By specifying a known directory and context, we can still use this tool with only minor changes (the optional flags added in this PR) and this gives us more ability to customize it to our use cases.
I'm aware that we could accomplish something similar with
--output-dir, by going in the opposite direction and running this tool from our API library while specifying the output as those specific repos. But I think controlling the CRD updates from each repo itself couples the CRD update with the corresponding, necessary dependency bump well.