🐛 Restore Gopkg.toml #176
Merged
🐛 Restore Gopkg.toml #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mengqiy |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
mengqiy
approved these changes
Apr 4, 2019
test.sh
Outdated
| @@ -135,3 +135,21 @@ golangci-lint run --disable-all \ | |||
| header_text "running go test" | |||
|
|
|||
| go test -mod=vendor ./pkg/... ./cmd/... -parallel 4 | |||
|
|
|||
| # ensure that Gopkg.{toml,lock} are up-to-date | |||
| header_test "ensuring that Gopkg.{toml,lock} are up to date..." | |||
There was a problem hiding this comment.
typo here. should be header_text
k8s-ci-robot
added
the
lgtm
DirectXMan12
force-pushed
the
bug/restore-gopkg-toml
branch
from
12dd858
to
8fffaa4
Compare
k8s-ci-robot
removed
the
lgtm
|
travis can't find |
This restores Gopkg.toml, and adds in some minimal testing to ensure that Gopkg.toml is up to date. Testing matches would be difficult due to differences in how go modules and dep capture the version of branch and non-version-tag-based dependencies.
DirectXMan12
force-pushed
the
bug/restore-gopkg-toml
branch
from
8fffaa4
to
7a25977
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores Gopkg.toml, and adds in some minimal testing to ensure
that Gopkg.toml is up to date. Testing matches would be difficult
due to differences in how go modules and dep capture the version of
branch and non-version-tag-based dependencies.