🐛 Fix incompatible CRDs #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CRD status field doesn't have omitempty on its fields, which means that they get serialized as null. However, the fields aren't marked as optional or nullable in the OpenAPI schema, which means they fail the client-side OpenAPI validation. This populates the known ones so that this doesn't happen. In the long term, we should figure out a better solution.
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
DirectXMan12
force-pushed
the
bug/incompatible-crds
branch
2 times, most recently
from
e310df3
to
192b99d
Compare
This adds a flag to CRD gen (`trivialVersions=<bool>`), which, when enabled, moves the storage schema into the root CRD, and wipes all version-level schemas. This makes generated CRDs compatible with pre-Kubernetes-1.13 clusters.
the printcolumn marker had some fields that are optional in kubernetes which were not marked as optional in the marker. This fixes that.
DirectXMan12
force-pushed
the
bug/incompatible-crds
branch
from
192b99d
to
92086f2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
sttts
reviewed
May 10, 2019
| // NB(directxman12): CRD's status doesn't have omitempty markers, which means things | ||
| // get serialized as null, which causes the validator to freak out. Manually set | ||
| // these to empty till we get a better solution. | ||
| crd.Status.Conditions = []apiext.CustomResourceDefinitionCondition{} |
There was a problem hiding this comment.
An upstream PR would be helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two fixes for generated CRDs:
printcolumnfields optional when appropriate