Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: 馃悰 Update known_types to add x-kubernetes-int-or-string for intStr #312

Closed
wants to merge 1 commit into from
Closed

WIP: 馃悰 Update known_types to add x-kubernetes-int-or-string for intStr #312

wants to merge 1 commit into from

Conversation

ukclivecox
Copy link

馃悰

Fixes #304

Note:

  • Have not committed go.sum- should I?
  • Its unclear what version controller-tools requires of dependant tools. I have taken the first update to apiextensions-apiserver that includes the commit: kubernetes/apiextensions-apiserver@7551f63

@k8s-ci-robot
Copy link
Contributor

Welcome @cliveseldon!

It looks like this is your first PR to kubernetes-sigs/controller-tools 馃帀. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 馃槂

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cliveseldon
To complete the pull request process, please assign droot
You can assign the PR to them by writing /assign @droot in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 28, 2019
@ukclivecox
Copy link
Author

/assign @mengqiy

@ukclivecox ukclivecox changed the title WIP: Update known_types to add x-kubernetes-int-or-string for intStr WIP: 馃悰 Update known_types to add x-kubernetes-int-or-string for intStr Aug 28, 2019
droot
droot reviewed Aug 28, 2019
View reviewed changes
go.mod
k8s.io/klog v0.2.0 // indirect
k8s.io/api v0.0.0-20190620085009-fd6d441bb4ee
k8s.io/apiextensions-apiserver v0.0.0-20190620085545-9a1be6d1ab4f
k8s.io/apimachinery v0.0.0-20190513181300-e403c24f3a75
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these corresponds to v1.15.x ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well is part of the initial changes for v1.15. If you go further there are also changes for the Webhooks which seem non-backwards compatible. So I'm not sure how this is supposed to be migrated:

kubernetes/api@77a6ece

This is why I need advice on how you conform this project to breaking changes such as above?

@mengqiy
Copy link
Member

mengqiy commented Sep 16, 2019

This PR need to be on top of #276 to have XIntOrString field.
/hold
Hold til #276 is merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2019
@marun
Copy link
Contributor

marun commented Sep 17, 2019

#276 has merged

@tamalsaha
Copy link
Contributor

tamalsaha commented Nov 15, 2019 •
edited

@cliveseldon , can you please rebase your pr? This is blocker for generating structural schema using kubebuilder. Thanks!

@tamalsaha tamalsaha mentioned this pull request Nov 15, 2019
Merged
@tamalsaha
Copy link
Contributor

FYI, I have opened a new pr with additional fixes #360

@k8s-ci-robot
Copy link
Contributor

@tamalsaha: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tamalsaha
Copy link
Contributor

This issue has been fixed in #360 . This pr can be closed.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 14, 2020
@k8s-ci-robot
Copy link
Contributor

@cliveseldon: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 15, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot left review comments

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@mengqiy mengqiy

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IntOrString is not structural in generated OpenAPIv3 CRD
7 participants
@ukclivecox @k8s-ci-robot @mengqiy @marun @tamalsaha @fejta-bot @droot