Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWNERS: add myself #1863

Merged
merged 1 commit into from Oct 22, 2018
Merged

OWNERS: add myself #1863

merged 1 commit into from Oct 22, 2018

Conversation

giuseppe
Copy link
Member

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@mrunalp
Copy link
Member

mrunalp commented Oct 22, 2018

👍 will wait for CI to come back. cc: @runcom

@rhatdan
Copy link
Contributor

rhatdan commented Oct 22, 2018

LGTM

1 similar comment
@runcom
Copy link
Member

runcom commented Oct 22, 2018

LGTM

@mrunalp
Copy link
Member

mrunalp commented Oct 22, 2018

/lgtm

@mrunalp mrunalp merged commit 1b6b7db into cri-o:master Oct 22, 2018
@runcom
Copy link
Member

runcom commented Oct 22, 2018

for reference, Giuseppe is the 4th contributor for commits number in crio as well as being always eager to help with issues! Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: giuseppe
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: feiskyer

If they are not already assigned, you can assign the PR to them by writing /assign @feiskyer in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @giuseppe. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants