Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

critest should cover UserNamespace #1348

Closed
AkihiroSuda opened this issue Feb 8, 2024 · 6 comments · Fixed by #1354
Closed

critest should cover UserNamespace #1348

AkihiroSuda opened this issue Feb 8, 2024 · 6 comments · Fixed by #1354
Assignees
@saschagrunert
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@AkihiroSuda
Copy link
Member

What would you like to be added:

CRI API supports UsernamespaceMode, but this doesn't seem covered in critest

Why is this needed:

For
@AkihiroSuda AkihiroSuda added kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 8, 2024
@AkihiroSuda AkihiroSuda mentioned this issue Feb 8, 2024
Merged
@AkihiroSuda
Copy link
Member Author

cc @rata

@saschagrunert
Copy link
Member

saschagrunert commented Feb 8, 2024 •
edited
Loading

Yeah I guess this was already on the plan for v1.30. Do you want to work on that @AkihiroSuda?

@rata
Copy link
Contributor

rata commented Feb 8, 2024

I fully agree. If any of you can help, it will be great! :)

@saschagrunert
Copy link
Member

I can, probably from next week. If @AkihiroSuda want to jump in then I'm happy to step back :)

@AkihiroSuda
Copy link
Member Author

Thanks

/assign @saschagrunert

saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 12, 2024
@saschagrunert
Add user namespaces tests
afbb71f 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert mentioned this issue Feb 12, 2024
Merged
@saschagrunert
Copy link
Member

Working towards the goal in #1354

saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 12, 2024
@saschagrunert
Add user namespaces tests
2a84587 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 12, 2024
@saschagrunert
Add user namespaces tests
3527be0 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 13, 2024
@saschagrunert
Add user namespaces tests
f3747eb 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 13, 2024
@saschagrunert
Add user namespaces tests
f0cbb20 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 15, 2024
@saschagrunert
Add user namespaces tests
edf57b7 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 15, 2024
@saschagrunert
Add user namespaces tests
e3ab308 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 15, 2024
@saschagrunert
Add user namespaces tests
1529408 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 15, 2024
@saschagrunert
Add user namespaces tests
32ca6ee 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 15, 2024
@saschagrunert
Add user namespaces tests
3493ea6 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 15, 2024
@saschagrunert
Add user namespaces tests
acc4855 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 15, 2024
@saschagrunert
Add user namespaces tests
daf0749 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 16, 2024
@saschagrunert
Add user namespaces tests
305242c 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 16, 2024
@saschagrunert
Add user namespaces tests
d923a2d 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 16, 2024
@saschagrunert
Add user namespaces tests
432d3f7 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 16, 2024
@saschagrunert
Add user namespaces tests
a662a96 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 16, 2024
@saschagrunert
Add user namespaces tests
9de3400 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 16, 2024
@saschagrunert
Add user namespaces tests
b66f2ac 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 16, 2024
@saschagrunert
Add user namespaces tests
13d5696 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 16, 2024
@saschagrunert
Add user namespaces tests
096d23b 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 16, 2024
@saschagrunert
Add user namespaces tests
4339650 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 16, 2024
@saschagrunert
Add user namespaces tests
5f2bb13 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 16, 2024
@saschagrunert
Add user namespaces tests
c883e9e 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 19, 2024
@saschagrunert
Add user namespaces tests
886e5c8 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 19, 2024
@saschagrunert
Add user namespaces tests
42e3896 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 20, 2024
@saschagrunert
Add user namespaces tests
457cebe 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 21, 2024
@saschagrunert
Add user namespaces tests
e093073 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 21, 2024
@saschagrunert
Add user namespaces tests
67dcfe8 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 21, 2024
@saschagrunert
Add user namespaces tests
560ec7e 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 21, 2024
@saschagrunert
Add user namespaces tests
93e33b3 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 21, 2024
@saschagrunert
Add user namespaces tests
ea2f4b5 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 21, 2024
@saschagrunert
Add user namespaces tests
28c22c4 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 29, 2024
@saschagrunert
Add user namespaces tests
c2e5f2c 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 29, 2024
@saschagrunert
Add user namespaces tests
0e07ac4 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 29, 2024
@saschagrunert
Add user namespaces tests
efb5f92 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/cri-tools that referenced this issue Feb 29, 2024
@saschagrunert
Add user namespaces tests
4d1e304 
Adding user namespaces tests for covering the `UsernamespaceMode`
supported by the CRI.

Fixes kubernetes-sigs#1348

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saschagrunert saschagrunert

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add user namespaces tests saschagrunert/cri-tools
3 participants
@rata @saschagrunert @AkihiroSuda