Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ginkgo version aligning #925

Closed
mikebrow opened this issue May 6, 2022 · 3 comments · Fixed by #930
Closed

ginkgo version aligning #925

mikebrow opened this issue May 6, 2022 · 3 comments · Fixed by #930
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@mikebrow
Copy link
Contributor

mikebrow commented May 6, 2022

We, containerd, are having problems moving up to v1.24.0 and post v1.24.0 critest with both parallel on and a skip and/or focus applied.

History here: containerd/containerd#6894

Noting also that k/k is on a different version of ginkgo and ginkgo has the requirement of the installed version matching the library. This may cause some versioning issues when doing both critest and e2e buckets. Let's discuss.

Cheers, Mike
@mikebrow mikebrow added kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node. labels May 6, 2022
@saschagrunert
Copy link
Member

We, containerd, are having problems moving up to v1.24.0 and post v1.24.0 critest with both parallel on and a skip and/or focus applied.

Is this something which has to be fixed in ginkgo?

Noting also that k/k is on a different version of ginkgo and ginkgo has the requirement of the installed version matching the library. This may cause some versioning issues when doing both critest and e2e buckets. Let's discuss.

There are also efforts of moving k/k to ginkgo v2: kubernetes/kubernetes#109111

fuweid added a commit to fuweid/cri-tools that referenced this issue May 11, 2022
@fuweid
cmd/critest: fix empty ginkgo flag's value issue
651ff15 
In commit 53ad8bb[1], the ginkgo uses
flags.StringVar for some flags, for instance, the --skip or --focus.

But in the following release of ginkgo(>=v1.15.0[2]), the ginkgo starts to
use string slice instead of the StringVar, which means we can't get the
user's input by the flags.Value.String()[3]. The String() always returns
empty value.

Based on that, we should use ginkgo API to generate flags instead of
manually handler in cri-test.

Reference:

[1]: https://github.com/kubernetes-sigs/cri-tools/blob/53ad8bb7f97e1b1d1c0c0634e43a3c2b8b07b718/vendor/github.com/onsi/ginkgo/config/config.go#L79
[2]: https://github.com/onsi/ginkgo/blob/v1.15.0/config/config.go#L84
[3]: https://github.com/onsi/ginkgo/blob/v1.15.0/config/config.go#L68-L71

fixes: kubernetes-sigs#925

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@fuweid fuweid mentioned this issue May 11, 2022
Merged
@mikebrow
Copy link
Contributor Author

missed this question @saschagrunert .. fu wei was taking a look, see pr ^

@saschagrunert
Copy link
Member

@mikebrow if #930 got merged, would you need a new release of cri-tools?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/critest: fix empty ginkgo flag's value issue fuweid/cri-tools
2 participants
@saschagrunert @mikebrow