Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added testing on 1.7 #1155

Merged
merged 1 commit into from
May 31, 2023
Merged

added testing on 1.7 #1155

merged 1 commit into from
May 31, 2023

Conversation

SergeyKanzhelev
Copy link
Member

What type of PR is this?

/kind cleanup
Fixes: #1154

@mikebrow

What this PR does / why we need it:

Added testing on 1.7 and testing on 1.6 latest instead of fixed version.

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 3, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 3, 2023
mikebrow
mikebrow approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@k8s-ci-robot
Copy link
Contributor

@mikebrow: changing LGTM is restricted to collaborators

In response to this:

LGTM on green

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@samuelkarp: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SergeyKanzhelev SergeyKanzhelev force-pushed the containerdVersions branch 2 times, most recently from cccdb15 to 78c2bb9 Compare May 4, 2023 00:40
mikebrow
mikebrow reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx

@SergeyKanzhelev
Copy link
Member Author

LGTM thx

still doesn't work. It skips all containerd tests in CI now. It doesn't like the ${{ replace() }} syntax.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 8, 2023
@SergeyKanzhelev
Copy link
Member Author

Tests before this PR:

build / lint and vendor check/ on ubuntu-20.04 (pull_request)
build / releases / on macos-10.15 (pull_request)
build / releases / on ubuntu-20.04 (pull_request)
cri-tools e2e test / ubuntu-latest (pull_request)
critest containerd / main / ubuntu-20.04 / io.containerd.runc.v1 / runc (pull_request)
critest containerd / main / ubuntu-20.04 / io.containerd.runc.v2 / crun (pull_request)
critest containerd / main / ubuntu-20.04 / io.containerd.runc.v2 / runc (pull_request)
critest containerd / main / ubuntu-20.04 / io.containerd.runtime.v1.linux / runc (pull_request)
critest containerd / main / windows-2019 / containerd-shim-runhcs-v1 / runc (pull_request)

critest containerd / v1.6.12 / ubuntu-20.04 / io.containerd.runc.v1 / runc (pull_request)
critest containerd / v1.6.12 / ubuntu-20.04 / io.containerd.runc.v2 / crun (pull_request)
critest containerd / v1.6.12 / ubuntu-20.04 / io.containerd.runc.v2 / runc (pull_request)
critest containerd / v1.6.12 / ubuntu-20.04 / io.containerd.runtime.v1.linux / runc (pull_request)
critest containerd / v1.6.12 / windows-2019 / containerd-shim-runhcs-v1 / runc (pull_request)

critest CRI-O / main / linux amd64 (pull_request) Successful in 3m
EasyCLA — EasyCLA check passed. You are authorized to contribute.
tide Pending — Not mergeable.

After:

build / lint and vendor check/ on ubuntu-20.04 (pull_request)
build / releases / on macos-10.15 (pull_request)
build / releases / on ubuntu-20.04 (pull_request)
cri-tools e2e test / ubuntu-latest (pull_request)
critest containerd / main / ubuntu-20.04 / io.containerd.runc.v1 / runc (pull_request)
critest containerd / main / ubuntu-20.04 / io.containerd.runc.v2 / crun (pull_request)
critest containerd / main / ubuntu-20.04 / io.containerd.runc.v2 / runc (pull_request)
critest containerd / main / ubuntu-20.04 / io.containerd.runtime.v1.linux / runc (pull_request)
critest containerd / main / windows-2019 / containerd-shim-runhcs-v1 / runc (pull_request)

critest containerd / release/1.6 / ubuntu-20.04 / io.containerd.runc.v1 / runc (pull_request)
critest containerd / release/1.6 / ubuntu-20.04 / io.containerd.runc.v2 / crun (pull_request)
critest containerd / release/1.6 / ubuntu-20.04 / io.containerd.runc.v2 / runc (pull_request)
critest containerd / release/1.6 / ubuntu-20.04 / io.containerd.runtime.v1.linux / runc (pull_request)
critest containerd / release/1.6 / windows-2019 / containerd-shim-runhcs-v1 / runc (pull_request)

critest containerd / release/1.7 / ubuntu-20.04 / io.containerd.runc.v1 / runc (pull_request)
critest containerd / release/1.7 / ubuntu-20.04 / io.containerd.runc.v2 / crun (pull_request)
critest containerd / release/1.7 / ubuntu-20.04 / io.containerd.runc.v2 / runc (pull_request)
critest containerd / release/1.7 / ubuntu-20.04 / io.containerd.runtime.v1.linux / runc (pull_request)
critest containerd / release/1.7 / windows-2019 / containerd-shim-runhcs-v1 / runc (pull_request)

critest CRI-O / main / linux amd64 (pull_request) Successful in 3m
EasyCLA — EasyCLA check passed. You are authorized to contribute.
tide Pending — Not mergeable.

@SergeyKanzhelev
Copy link
Member Author

@mikebrow can you please add formal lgtm here?

mikebrow
mikebrow approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot
Copy link
Contributor

@mikebrow: changing LGTM is restricted to collaborators

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikebrow, samuelkarp, saschagrunert, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
@saschagrunert saschagrunert merged commit 32ba425 into kubernetes-sigs:master May 31, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@mikebrow mikebrow mikebrow approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@haircommander haircommander Awaiting requested review from haircommander

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Containerd in CI matrix to latest 1.6
5 participants
@SergeyKanzhelev @k8s-ci-robot @saschagrunert @samuelkarp @mikebrow