Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update actions using node12 to latest version using node16 #1187

Merged
merged 2 commits into from
Jun 9, 2023
Merged

update actions using node12 to latest version using node16 #1187

merged 2 commits into from
Jun 9, 2023

Conversation

akhilerm
Copy link
Contributor

@akhilerm akhilerm commented Jun 8, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update all the github actions using node12 to version that use node16 since node12 actions are deprecated ref

  • update actions/checkout@v2 -> v3
  • update actions/cache@v2 -> v3
  • update actions/setup-go@v2 -> v4

The PR also adds a dependabot config to auto update the github actions when new versions are released.

Which issue(s) this PR fixes:

Special notes for your reviewer:

cache has been set to disabled for setup-go due to actions/setup-go#368

Does this PR introduce a user-facing change?

NONE

@akhilerm
update actions using node12
806c66f 
update all the github actions using node12 to version that use node16

- update actions/checkout@v2 -> v3
- update actions/cache@v2 -> v3
- update actions/setup-go@v2 -> v4

cache has been set to disabled for setup-go
due to actions/setup-go#368

Signed-off-by: Akhil Mohan <makhil@vmware.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @akhilerm!

It looks like this is your first PR to kubernetes-sigs/cri-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cri-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 8, 2023
saschagrunert
saschagrunert reviewed Jun 8, 2023
View reviewed changes
.github/workflows/build.yml
uses: actions/setup-go@v2
uses: actions/setup-go@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a dependabot config to update them regularly as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. added the dependabot config.

@akhilerm
add dependabot config to update github actions
c3a28fe 
Signed-off-by: Akhil Mohan <makhil@vmware.com>
saschagrunert
saschagrunert approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhilerm, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit b98b116 into kubernetes-sigs:master Jun 9, 2023
22 checks passed
@akhilerm akhilerm deleted the update-node12-actions branch June 9, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@haircommander haircommander Awaiting requested review from haircommander

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akhilerm @k8s-ci-robot @saschagrunert