The --filter flag improvments #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/M
kwilczynski
reviewed
Feb 23, 2024
roman-kiselenko
force-pushed
the
feature/image-filter-changes
branch
from
bb4c653
to
17b53ea
Compare
kwilczynski
reviewed
Feb 23, 2024
cmd/crictl/image.go
Outdated
| @@ -147,7 +147,7 @@ var listImageCommand = &cli.Command{ | |||
| &cli.StringSliceFlag{ | |||
| Name: "filter", | |||
| Aliases: []string{"f"}, | |||
| Usage: "The filtering flag format is of 'dangling=(true/false)', 'reference=regex', '(before|since)=<image-name>[:<tag>]|<image id>|<image@digest>'", | |||
| Usage: "Filter output based on provided conditions.\nEach filter has an AND style relationship with the other others.\nAvailable filters: \n* dangling=BOOL\n* reference=/Regular Expression/\n* before=<image-name>[:<tag>]|<image id>|<image@digest>\n* since=<image-name>[:<tag>]|<image id>|<image@digest>", | |||
There was a problem hiding this comment.
Perhaps?
Suggested change
| Usage: "Filter output based on provided conditions.\nEach filter has an AND style relationship with the other others.\nAvailable filters: \n* dangling=BOOL\n* reference=/Regular Expression/\n* before=<image-name>[:<tag>]|<image id>|<image@digest>\n* since=<image-name>[:<tag>]|<image id>|<image@digest>", | |
| Usage: "Filter output based on provided conditions.\nAvailable filters: \n* dangling=(boolean - true or false)\n* reference=/regular expression/\n* before=<image-name>[:<tag>]|<image id>|<image@digest>\n* since=<image-name>[:<tag>]|<image id>|<image@digest>\nMultiple filters can be combined together.", |
Produces:
--filter value, -f value [ --filter value, -f value ] Filter output based on provided conditions.
Available filters:
* dangling=(boolean - true or false)
* reference=/regular expression/
* before=<image-name>[:<tag>]|<image id>|<image@digest>
* since=<image-name>[:<tag>]|<image id>|<image@digest>
Multiple filters can be combined together.I wish the CLI package aligned usage to the right nicely.
kwilczynski
reviewed
Feb 23, 2024
docs/crictl.1
Outdated
| @@ -461,7 +461,7 @@ k8s.gcr.io/pause 3.1 da86e6ba6ca19 742kB | |||
|
|
|||
| .SS Filter images | |||
| .PP | |||
| The following filters are available \fB\fC\-\-filter\fR, \fB\fC\-f\fR, filters are chainable and processed in the declared order: | |||
| The following filters are available \fB\fC\-\-filter\fR, \fB\fC\-f\fR\&. | |||
There was a problem hiding this comment.
This file might need to get regenerated.
* handle regexp error * better usage info * better documentation Signed-off-by: roman-kiselenko <roman.kiselenko.dev@gmail.com>
roman-kiselenko
force-pushed
the
feature/image-filter-changes
branch
from
17b53ea
to
fd867e1
Compare
|
/approve |
|
@kwilczynski: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@roman-kiselenko, thank you! Looks good! |
saschagrunert
approved these changes
Feb 26, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, roman-kiselenko, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of changes from PR #1359
Follows @kwilczynski comments.
Better usage:
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
A bunch of changes from previous PR review.
None
Does this PR introduce a user-facing change?
None