Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort flags for all commands. #207

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Conversation

Random-Liu
Copy link
Contributor

@Random-Liu Random-Liu commented Nov 29, 2017

Sort all flags.

Before:

$ crictl ps --help
NAME:
   crictl ps - List containers

USAGE:
   crictl ps [command options] [arguments...]

OPTIONS:
   --verbose, -v             Show verbose information for containers
   --id value                Filter by container id
   --sandbox value           Filter by sandbox id
   --state value             Filter by container state
   --label value             Filter by key=value label
   --quiet                   Only display container IDs
   --output value, -o value  Output format, One of: json|yaml|table
   --all, -a                 Show all containers
   --latest, -l              Show recently created container (includes all states)
   --last value, -n value    Show last n recently created containers (includes all states) (default: 0)
   --no-trunc                Show output without truncating the ID

After:

$ crictl ps --help
NAME:
   crictl ps - List containers

USAGE:
   crictl ps [command options] [arguments...]

OPTIONS:
   --all, -a                 Show all containers
   --id value                Filter by container id
   --label value             Filter by key=value label
   --last value, -n value    Show last n recently created containers (includes all states) (default: 0)
   --latest, -l              Show recently created container (includes all states)
   --no-trunc                Show output without truncating the ID
   --output value, -o value  Output format, One of: json|yaml|table
   --quiet                   Only display container IDs
   --sandbox value           Filter by sandbox id
   --state value             Filter by container state
   --verbose, -v             Show verbose information for containers

Signed-off-by: Lantao Liu <lantaol@google.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2017
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feiskyer feiskyer merged commit 0a9595c into kubernetes-sigs:master Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants