Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building on Windows #225

Merged
merged 2 commits into from
Jan 22, 2018
Merged

Fix building on Windows #225

merged 2 commits into from
Jan 22, 2018

Conversation

feiskyer
Copy link
Member

This is the first step of #223, it fixes building on Windows and add support of tcp endpoints.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 17, 2018
@feiskyer
Copy link
Member Author

/assign @Random-Liu

Random-Liu
Random-Liu reviewed Jan 17, 2018
View reviewed changes
Copy link
Contributor

@Random-Liu Random-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

Makefile Outdated
@@ -55,6 +55,12 @@ clean:
find . -name \*~ -delete
find . -name \#\* -delete

cross: check-gopath
GOOS=windows $(GO) build -o $(CURDIR)/_output/critest.exe \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many indents?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

JiangtianLi
JiangtianLi approved these changes Jan 18, 2018
View reviewed changes
Copy link

@JiangtianLi JiangtianLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feiskyer feiskyer merged commit bd487e2 into kubernetes-sigs:master Jan 22, 2018
@feiskyer feiskyer deleted the windows branch January 22, 2018 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Random-Liu Random-Liu Random-Liu left review comments

@JiangtianLi JiangtianLi JiangtianLi approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@feiskyer @Random-Liu @JiangtianLi @k8s-ci-robot