Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick #332 #338

Merged
merged 2 commits into from
Jul 11, 2018
Merged

Cherrypick #332 #338

merged 2 commits into from
Jul 11, 2018

Conversation

Random-Liu
Copy link
Contributor

Cherrypick #332 into release/1.11.

This feature is backward compatible, and is very useful for users. Let's cherrypick it into 1.11 release, and update the crictl version in Kubernetes.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 11, 2018
@Random-Liu Random-Liu added this to the v1.11.1 milestone Jul 11, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2018
@feiskyer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2018
@feiskyer feiskyer merged commit fdd62fa into kubernetes-sigs:release-1.11 Jul 11, 2018
@Random-Liu Random-Liu deleted the cherrypick-#332 branch July 12, 2018 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@feiskyer feiskyer

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Random-Liu @feiskyer @k8s-ci-robot @yujuhong