Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly returns errors when the output format is not supported #354

Merged
merged 1 commit into from
Jul 14, 2018

Conversation

yujuhong
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 13, 2018
@yujuhong
Copy link
Contributor Author

/cc @Random-Liu

@Random-Liu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2018
@Random-Liu
Copy link
Contributor

@yujuhong It seems that you are hitting a panic? We should probably cherrypick.

@Random-Liu
Copy link
Contributor

NVM, there is no panic... I misremembered. Then we may not need a cherry-pick.

@Random-Liu Random-Liu merged commit f95ba2f into kubernetes-sigs:master Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants