Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crictl ps and crictl pods. #363

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Fix crictl ps and crictl pods. #363

merged 1 commit into from
Aug 3, 2018

Conversation

Random-Liu
Copy link
Contributor

@yanxuean This should fix the issue for you.

Signed-off-by: Lantao Liu lantaol@google.com

@Random-Liu
Fix crictl ps and crictl pods.
a7680af 
Signed-off-by: Lantao Liu <lantaol@google.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 3, 2018
@yujuhong
Copy link
Contributor

yujuhong commented Aug 3, 2018

This is ok to fix the bug, but we probably want a more clear way to set default in the future.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2018
@Random-Liu Random-Liu merged commit ac32e84 into kubernetes-sigs:master Aug 3, 2018
@Random-Liu Random-Liu deleted the fix-crictl-pods-ps branch August 3, 2018 23:56
@yanxuean
Copy link
Contributor

yanxuean commented Aug 4, 2018

I am late. It will be better if we can remove "table" and "default" case.
But these code was added in #206.
In fact, I don't know what it mean:) Maybe @mikebrow know it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Random-Liu @yujuhong @yanxuean @k8s-ci-robot