crictl: do not error out if one rm operation fails #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crictl would stop trying to remove other containers in case of error. crictl rm 95bfe31395ba 95bf0e31395b FATA[0000] Removing the container "95bfe31395ba" failed: rpc error: code = Unknown desc = container with ID starting with 95bfe31395ba not found: ID does not exist Signed-off-by: Nirmoy Das <ndas@suse.de>
k8s-ci-robot
added
size/XS
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, nirmoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crictl would stop trying to remove other containers in case of error.
crictl rm 95bfe31395ba 95bf0e31395b
FATA[0000] Removing the container "95bfe31395ba" failed: rpc error: code = Unknown desc = container with ID starting with 95bfe31395ba not found: ID does not exist
Signed-off-by: Nirmoy Das ndas@suse.de