Set SelinuxRelabel to true for bind mounts #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The volume mount tests were not setting selinuxRelabel to true, which was causing the paths mounted in to not have the correct label. We caught this with the SELinux rework we are doing in cri-o. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
k8s-ci-robot
added
size/XS
|
This should be a noop if SELinux is disabled. Currently if SELinux is enabled and the containers are running with a locked down container type like container_t they would get permission denied when trying to read/write these volumes. With the Relabel, the volumes will have a label that the container_t processes are allowed to use. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The volume mount tests were not setting selinuxRelabel to
true, which was causing the paths mounted in to not have the
correct label. We caught this with the SELinux rework we are
doing in cri-o.
The Selinux rework PR: cri-o/cri-o#2096
Signed-off-by: Urvashi Mohnani umohnani@redhat.com