support live monitoring critool stats #467
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
ping @feiskyer |
cmd/crictl/display.go
Outdated
| namespace = "NAMESPACE" | ||
| size = "SIZE" | ||
| tag = "TAG" | ||
| digest = "DIGEST" |
There was a problem hiding this comment.
Could you add a prefix for those const names?
cmd/crictl/image.go
Outdated
| "github.com/sirupsen/logrus" | ||
| "github.com/urfave/cli" | ||
| "golang.org/x/net/context" | ||
| pb "k8s.io/kubernetes/pkg/kubelet/apis/cri/runtime/v1alpha2" | ||
| "sort" | ||
| "strings" | ||
| ) |
There was a problem hiding this comment.
nit: move those two to the first group
cmd/crictl/stats.go
Outdated
| if duration == 0 { | ||
| return fmt.Errorf("cpu stat is not updated during sample") | ||
| display := newTableDisplay(20, 1, 3, ' ', 0) | ||
| for range time.Tick(500 * time.Millisecond) { |
There was a problem hiding this comment.
Could we add a new option for this, e.g. --watch or -w?
There was a problem hiding this comment.
I think live monitoring is enabled by default, like docker stats. So do we still need this watch option?
There was a problem hiding this comment.
WDYT? @feiskyer Do we really need this option? What is the use case of non live monitoring?
There was a problem hiding this comment.
just like kubectl top, it only show the output for one time. We can enable it by default, but it could be disabled by an option
There was a problem hiding this comment.
Thanks for your reply, I have added this -w option to enable live monitoring, PTAL.
Signed-off-by: yeya24 <yb532204897@gmail.com> fix gometalinter Signed-off-by: yeya24 <yb532204897@gmail.com> add option watch Signed-off-by: yeya24 <yb532204897@gmail.com>
yeya24
force-pushed
the
feature/refactor-display
branch
from
f24ad23
to
7cf1e74
Compare
|
thanks. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, yeya24 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Close and re-open to trigger the failed travis CI. |
Signed-off-by: yeya24 yb532204897@gmail.com
Add support for live critool stats;
Also refactor the table display