Switch to go-modules #490
Switch to go-modules #490
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
saschagrunert
force-pushed
the
go-modules
branch
from
834e3d0
to
c9e207a
Compare
|
The idea looks good, but I wonder why so many vendor files are removed and updated? Generally, if we only switch go modules, the vendor files should still be same, right? |
|
/cc @yujuhong @Random-Liu |
Ah I'm sorry, I also updated the dependencies as well. The thing is that dependent projects switched to go modules too, which will lead into ma much cleaner go.mod file. |
|
@saschagrunert Thanks, then it makes sense. |
| k8s.io/apimachinery v0.0.0 | ||
| k8s.io/client-go v11.0.0+incompatible | ||
| k8s.io/cri-api v0.0.0 | ||
| k8s.io/kubernetes v0.0.0 |
There was a problem hiding this comment.
v0.0.0 means latest. For k8s.io dependencies, do we need to change this to a specific version, e.g. v1.15.0?
There was a problem hiding this comment.
Not necessarily since we override it in the replace section: k8s.io/kubernetes => k8s.io/kubernetes v1.15.1
This removes the old vendoring for go module support. We also add an additional verification step to travis. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
saschagrunert
force-pushed
the
go-modules
branch
from
c9e207a
to
8dbabea
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This removes the old vendoring for go module support. We also add an
additional verification step to travis. Documentation has been updated
as well.
After that, I would like to update to the latest Kubernetes alpha to propose the new CRI API changes which are introduced with dual stack IPv6 support, WDYT?