Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The check should not have 1s timeout. #517

Merged
merged 1 commit into from Aug 30, 2019
Merged

The check should not have 1s timeout. #517

merged 1 commit into from Aug 30, 2019

Conversation

Random-Liu
Copy link
Contributor

@Random-Liu Random-Liu commented Aug 30, 2019 •
edited

For containerd/cri#1257.

We should not set the 1 second timeout on the check exec, it may timeout.

This is especially important on windows, because the exec is slower. :)

/cc @yujuhong @feiskyer
Signed-off-by: Lantao Liu lantaol@google.com

@Random-Liu
The check should not have timeout.
3d826ae 
Signed-off-by: Lantao Liu <lantaol@google.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 30, 2019
@Random-Liu Random-Liu changed the title The check should not have timeout. The check should not have 1s timeout. Aug 30, 2019
saschagrunert
saschagrunert approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Random-Liu
Copy link
Contributor Author

Apply lgtm based on #517 (review)

@Random-Liu Random-Liu added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit 303e219 into kubernetes-sigs:master Aug 30, 2019
@Random-Liu Random-Liu deleted the no-timeout-for-check branch August 30, 2019 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@feiskyer feiskyer

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Random-Liu @k8s-ci-robot @saschagrunert @feiskyer @yujuhong