Download golangci-lint via wget

[haircommander]

Kubernetes now requires golang 1.13.4. When using golang 1.13.4 to build critest, we run into golangci-lint#659. Fix this with a couple of changes:

• install the golangci-lint binary for 1.17.1 with curl (similar to how CRI-O currently does), instead of using go mods
  • this includes dropping golangci-lint on ppc (which shouldn't matter)
  • which also includes breaking make install.tools into two different targets: lint and ginkgo
• bump the go version used by travis to 1.13 (because kubelet now requires 1.13.4 to build)
• revendor cri-tools with golang 1.13 (using the command: podman run --privileged --rm --env HOME=/root -v $PWD:/src -w /src golang:1.13 make vendor)

[k8s-ci-robot]

Welcome @haircommander!

It looks like this is your first PR to kubernetes-sigs/cri-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cri-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[haircommander]

@saschagrunert @mrunalp @Random-Liu PTAL

[saschagrunert]

Ah, interesting. Can we remove it from vendoring at all and just download the binary via the curl script, like we do in CRI-O? I recently hit compilation issues with golangci-lint and they recommend to use their prebuilt ones.

[haircommander]

@saschagrunert good idea, fixed!

[saschagrunert]

LGTM

[saschagrunert]

@haircommander we have to exclude the golangci lint check for travis on ppc, because it is not supported right now. :-/

[saschagrunert]

@mrunalp @feiskyer @Random-Liu PTAL

[haircommander]

huzzah, (finally) green tests. @mrunalp @feiskyer @Random-Liu PTAL

[mrunalp]

/lgtm

[mrunalp]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment