crictl: Adds support for updating resource limits for Windows Containers #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fields supported in the WindowsContainerResources are: - CpuCount: Number of CPUs available to the container. Default: 0 (not specified). - CpuMaximum: Specifies the portion of processor cycles that this container can use as a percentage times 100. - CpuShares: CPU shares (relative weight vs. other containers). Default: 0 (not specified). - MemoryLimitInBytes: Memory limit in bytes. Default: 0 (not specified).
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/S
|
this looks good, but have you validated whether any runtimes (e.g. containerd) support this behavior? |
|
Support is being added here: containerd/containerd#5778 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: claudiubelu, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/sig windows
What this PR does / why we need it:
The fields supported in the WindowsContainerResources are:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?