Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/critest: fix empty ginkgo flag's value issue #930

Merged
merged 1 commit into from
May 12, 2022
Merged

cmd/critest: fix empty ginkgo flag's value issue #930

merged 1 commit into from
May 12, 2022
+38 −3

Commits on May 11, 2022

  1. cmd/critest: fix empty ginkgo flag's value issue 

    In commit 53ad8bb[1], the ginkgo uses
flags.StringVar for some flags, for instance, the --skip or --focus.

But in the following release of ginkgo(>=v1.15.0[2]), the ginkgo starts to
use string slice instead of the StringVar, which means we can't get the
user's input by the flags.Value.String()[3]. The String() always returns
empty value.

Based on that, we should use ginkgo API to generate flags instead of
manually handler in cri-test.

Reference:

[1]: https://github.com/kubernetes-sigs/cri-tools/blob/53ad8bb7f97e1b1d1c0c0634e43a3c2b8b07b718/vendor/github.com/onsi/ginkgo/config/config.go L79
[2]: https://github.com/onsi/ginkgo/blob/v1.15.0/config/config.go L84
[3]: https://github.com/onsi/ginkgo/blob/v1.15.0/config/config.go L68-L71

Signed-off-by: Wei Fu <fuweid89@gmail.com>
    @fuweid
    fuweid committed May 11, 2022
    Configuration menu
    Copy the full SHA
    d4fe3e7 View commit details
    Browse the repository at this point in the history