Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add default implementation for providers #151

Merged
merged 2 commits into from
May 3, 2023
Merged

feat: add default implementation for providers #151

merged 2 commits into from
May 3, 2023

Conversation

JorTurFer
Copy link
Contributor

@JorTurFer JorTurFer commented Apr 24, 2023 •
edited

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

Fixes #150

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If custom-metrics-apiserver contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @JorTurFer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JorTurFer JorTurFer mentioned this pull request Apr 24, 2023
Merged
2 tasks
@dgrisonnet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2023
@JorTurFer JorTurFer marked this pull request as ready for review April 27, 2023 22:55
@JorTurFer JorTurFer changed the title WIP - feat: add default implementation for providers feat: add default implementation for providers Apr 27, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2023
@JorTurFer
Copy link
Contributor Author

I think that some changes are required in the infra level because it has started the fails when I bumped deps and go version.
Am I right @dgrisonnet ?

@dgrisonnet
Copy link
Member

Yes, I need to update the infra image, I'll do that tomorrow

@JorTurFer
Copy link
Contributor Author

Yes, I need to update the infra image, I'll do that tomorrow

Sure, no rush at all, I asked just to know if there was something missing from my side :)

@dgrisonnet
Copy link
Member

Do you need the dependency update in this PR? Otherwise I'd prefer having it in a separate PR if you don't mind since it is easier to track when I create the release note.

@JorTurFer
Copy link
Contributor Author

JorTurFer commented Apr 27, 2023 •
edited

Do you need the dependency update in this PR? Otherwise I'd prefer having it in a separate PR if you don't mind since it is easier to track when I create the release note.

sure, it's done :)

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 27, 2023
@dgrisonnet dgrisonnet mentioned this pull request Apr 28, 2023
Merged
@JorTurFer JorTurFer force-pushed the expose-single-metric branch 2 times, most recently from 2c72c54 to 8db01cc Compare April 28, 2023 20:16
@JorTurFer
feat: add default implementation for providers
4402792 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Contributor Author

I have renamed the metric names to follow tha k8s naming:
image
All the metrics go all together without underscores 😄

dgrisonnet
dgrisonnet reviewed May 3, 2023
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit and we are good to go :) Thanks @JorTurFer

pkg/provider/defaults/default_metric_providers.go Outdated Show resolved Hide resolved
pkg/provider/defaults/default_metric_providers.go Outdated Show resolved Hide resolved
dgrisonnet
dgrisonnet approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, JorTurFer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit c68a98e into kubernetes-sigs:master May 3, 2023
5 checks passed
@dgrisonnet dgrisonnet mentioned this pull request May 3, 2023
Closed
@JorTurFer JorTurFer deleted the expose-single-metric branch May 3, 2023 10:29
@JorTurFer JorTurFer mentioned this pull request May 18, 2023
Closed
@JorTurFer JorTurFer mentioned this pull request Aug 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet approved these changes

@olivierlemasle olivierlemasle Awaiting requested review from olivierlemasle

Assignees

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we rethink the response of listing requests?
3 participants
@JorTurFer @k8s-ci-robot @dgrisonnet