Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s 1.27: update docs and README #1116

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Apr 12, 2023

Closes #1080

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2023
@ingvagabund
Copy link
Contributor

Let's wait here until we decide at which commit we branch

@a7i
Copy link
Contributor Author

a7i commented Apr 12, 2023

/hold

I also need #1109 merged so I can rebase

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2023
@damemi
Copy link
Contributor

damemi commented Apr 12, 2023

Let's wait here until we decide at which commit we branch

We still have the weird Helm dependency on the latest tagged image that messes up the release guide a bit. I'm working on an outline to address that, but for this release here's what I propose:

  1. We finish all code merges for v0.27
  2. Tag v0.27
  3. Merge this PR (so we get an automatic build that's tagged with v0.27)
  4. Promote the v0.27 image upstream
  5. Finish the release process with Helm chart updates

Basically since this is just a docs change, we use that as the trigger post-tag to unblock the Helm chart updates. Does that sound good?

@a7i
Copy link
Contributor Author

a7i commented Apr 12, 2023

Let's wait here until we decide at which commit we branch

We still have the weird Helm dependency on the latest tagged image that messes up the release guide a bit. I'm working on an outline to address that, but for this release here's what I propose:

  1. We finish all code merges for v0.27
  2. Tag v0.27
  3. Merge this PR (so we get an automatic build that's tagged with v0.27)
  4. Promote the v0.27 image upstream
  5. Finish the release process with Helm chart updates

Basically since this is just a docs change, we use that as the trigger post-tag to unblock the Helm chart updates. Does that sound good?

Sounds good! I'll try to document this for next release project (if not made already)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2023
@a7i
Copy link
Contributor Author

a7i commented May 3, 2023

@damemi tag has been created

@damemi
Copy link
Contributor

damemi commented May 3, 2023

@damemi tag has been created

Awesome, thanks! Merging this so we can get a build for v0.27. Then we just need the image promotion, and that will unblock the Helm PRs
/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 3, 2023
@a7i
Copy link
Contributor Author

a7i commented May 4, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit eeafdb2 into kubernetes-sigs:master May 4, 2023
9 checks passed
@a7i a7i deleted the docs-1.27 branch May 4, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update version references in docs and readme
4 participants