-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit-test: add necessary ownerRef to the pod. #1445
Conversation
Welcome @zhifei92! |
Hi @zhifei92. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Good catch. Thank you. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There are cases where Pods have not had ownerReferences added, leading to certain test scenarios not yielding the expected outcomes. For instance, in the scenario "case: without priorities, but excluding namespaces," the reason pod1- pod5 were not evicted was due to "the Pod does not have any ownerReferences," as opposed to a namespace mismatch, because these Pods were not configured with ownerReferences.
And I haven't fixed "case: without priorities, but include only default namespace", because LowNodeUtilization does not support
inclusion
. I will proceed with this work wheninclusion
is supported.descheduler/pkg/framework/plugins/nodeutilization/lownodeutilization_test.go
Lines 227 to 251 in cdbd101
BTW, why
LowNodeUtilization
does not supportnamespace inclusion
?