Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LowNodeUtilization: use clientset in testing, drop all custom reactors #385

Merged
merged 1 commit into from Aug 31, 2020
Merged

LowNodeUtilization: use clientset in testing, drop all custom reactors #385

merged 1 commit into from Aug 31, 2020

Conversation

ingvagabund
Copy link
Contributor

SSIA

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 25, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 25, 2020
@ingvagabund ingvagabund mentioned this pull request Aug 25, 2020
Merged
@ingvagabund ingvagabund force-pushed the low-node-utilization-use-clientset-in-testing branch from 93fd4bd to 4e152a2 Compare August 25, 2020 13:44
@seanmalloy
Copy link
Member

/lgtm
/assign @damemi
/kind cleanup

This is required for #371

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 26, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2020
@seanmalloy
Copy link
Member

@damemi this PR will unblock the update to Go 1.15.

damemi
damemi approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, otherwise lgtm
/approve
/hold
(hold for the double check on removing newFake, remove at will)

pkg/descheduler/strategies/lownodeutilization_test.go
@@ -803,29 +803,21 @@ func TestWithTaints(t *testing.T) {
objs = append(objs, pod)
}

fakePtr := newFake(objs...)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is newFake called anywhere else? I don't see it used in this file anymore so we can remove it then right?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2020
@ingvagabund ingvagabund force-pushed the low-node-utilization-use-clientset-in-testing branch from 4e152a2 to d27f644 Compare August 31, 2020 18:38
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 31, 2020
@ingvagabund
Copy link
Contributor Author

newFake function removed
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2020
damemi
damemi approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 03dbc93 into kubernetes-sigs:master Aug 31, 2020
@ingvagabund ingvagabund deleted the low-node-utilization-use-clientset-in-testing branch August 31, 2020 18:50
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#385 from ingvagabund/low-node-util…
eb225db 
…ization-use-clientset-in-testing

LowNodeUtilization: use clientset in testing, drop all custom reactors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi approved these changes

@k82cn k82cn Awaiting requested review from k82cn

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@seanmalloy seanmalloy

@damemi damemi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ingvagabund @seanmalloy @k8s-ci-robot @damemi