Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table of contents generator/verify script #518

Merged
merged 4 commits into from
Mar 8, 2021
Merged

Add table of contents generator/verify script #518

merged 4 commits into from
Mar 8, 2021

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Mar 8, 2021

Replaces #516 with the sigs.k8s.io/mdtoc generator
/kind documentation

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 8, 2021
damemi
damemi commented Mar 8, 2021
View reviewed changes
Copy link
Contributor Author

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @seanmalloy @ingvagabund

@ingvagabund
Copy link
Contributor

/lgtm
/hold
@seanmalloy setting hold so you can review as well

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021
@seanmalloy
Copy link
Member

@damemi I added two small inline suggestions on shell scripts.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021
@damemi
Copy link
Contributor Author

damemi commented Mar 8, 2021

Thanks @seanmalloy, updated

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seanmalloy
Copy link
Member

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6abfa23 into kubernetes-sigs:master Mar 8, 2021
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#518 from damemi/sigs-k8s-mdtoc
68cac1a 
Add table of contents generator/verify script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmalloy seanmalloy seanmalloy approved these changes

@k82cn k82cn Awaiting requested review from k82cn

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@seanmalloy seanmalloy

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@damemi @ingvagabund @seanmalloy @k8s-ci-robot