Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document That Descheduler Considers StatefulSets For Eviction #520

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Document That Descheduler Considers StatefulSets For Eviction #520

merged 2 commits into from
Mar 23, 2021

Conversation

seanmalloy
Copy link
Member

Similar to ReplicaSet, ReplicationController, and Jobs pods with a
StatefulSet metadata.ownerReference are considered for eviction.
Document this, so that it is clear to end users.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2021
@seanmalloy
Copy link
Member Author

/kind documentation
/assign @damemi
/cc @ingvagabund

Part of #519

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 9, 2021
@seanmalloy seanmalloy mentioned this pull request Mar 9, 2021
Closed
3 tasks
ingvagabund
ingvagabund reviewed Mar 9, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
ingvagabund
ingvagabund reviewed Mar 9, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
ingvagabund
ingvagabund reviewed Mar 10, 2021
View reviewed changes
README.md Show resolved Hide resolved
@ingvagabund
Copy link
Contributor

@seanmalloy worth mentioning StatefulSet in https://github.com/kubernetes-sigs/descheduler/blame/master/README.md#L549 as well.

@seanmalloy
Copy link
Member Author

@seanmalloy worth mentioning StatefulSet in https://github.com/kubernetes-sigs/descheduler/blame/master/README.md#L549 as well.

I believe I already took care of this, but let me know if I'm not understanding correctly.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2021
@ingvagabund
Copy link
Contributor

I believe I already took care of this, but let me know if I'm not understanding correctly.

Right, sorry, looking into wrong README.md :)

@ingvagabund
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2021
@seanmalloy
Copy link
Member Author

@damemi and @ingvagabund I added the initial unit tests for StatefulSets. This PR is ready for review again. If it is alright with you I will add the StatefulSet e2e tests in a separate PR.

@seanmalloy
Copy link
Member Author

Also, I can squash the two documentation commits into a single commit once we think the changes are good.

@ingvagabund
Copy link
Contributor

Looks good, please squash

@seanmalloy
Document That Descheduler Considers StatefulSets For Eviction
56e4dac 
Similar to ReplicaSet, ReplicationController, and Jobs pods with a
StatefulSet metadata.ownerReference are considered for eviction.
Document this, so that it is clear to end users.
@seanmalloy
Add Initial Unit Tests For StatefulSets
92740a2
@seanmalloy
Copy link
Member Author

Looks good, please squash

@ingvagabund and @damemi it is squashed into two commits. One for the doc updates and one for the unit test updates.

@ingvagabund
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6ca4479 into kubernetes-sigs:master Mar 23, 2021
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#520 from KohlsTechnology/statefuls…
8f96942 
…et-docs

Document That Descheduler Considers StatefulSets For Eviction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@damemi damemi Awaiting requested review from damemi

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@damemi damemi

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seanmalloy @ingvagabund @k8s-ci-robot @damemi