Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go.mod to be min 1.19 and golangci-lint #226

Merged
merged 5 commits into from
Mar 25, 2023
Merged

Update go.mod to be min 1.19 and golangci-lint #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a3af1e3
update go modules to have go 1.19 as minimun
cpanato Mar 20, 2023
492ca94
update golangci-lint to v1.52.0
cpanato Mar 20, 2023
67cda5d
fix lints
cpanato Mar 20, 2023
2501522
remove deprecated lints
cpanato Mar 20, 2023
938a274
fix lints
cpanato Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ linters:
enable:
- asciicheck
- bodyclose
- deadcode
- depguard
- dogsled
- dupl
Expand All @@ -40,13 +39,11 @@ linters:
- rowserrcheck
- sqlclosecheck
- staticcheck
- structcheck
- stylecheck
- typecheck
- unconvert
- unparam
- unused
- varcheck
- whitespace

linters-settings:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module sigs.k8s.io/e2e-framework

go 1.18
go 1.19

require (
github.com/vladimirvivien/gexe v0.2.0
Expand Down
2 changes: 1 addition & 1 deletion hack/verify-golangci-lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ set -o errexit
set -o nounset
set -o pipefail

VERSION=v1.46.2
VERSION=v1.52.0
URL_BASE=https://raw.githubusercontent.com/golangci/golangci-lint
URL=$URL_BASE/$VERSION/install.sh

Expand Down
2 changes: 1 addition & 1 deletion klient/decoder/decoder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ func IgnoreErrorHandler(handler HandlerFunc, errorMatcher func(err error) bool)
}

// NoopHandler returns a Handler func that only returns nil
func NoopHandler(r *resources.Resources, opts ...resources.DeleteOption) HandlerFunc {
func NoopHandler(_ *resources.Resources, _ ...resources.DeleteOption) HandlerFunc {
return func(ctx context.Context, obj k8s.Object) error {
return nil
}
Expand Down