Refactor type Environment and env Config to support new typeklient.Client
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vladimirvivien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
sig/testing
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
cncf-cla: yes
vladimirvivien
changed the title
klient.Client
k8s-ci-robot
added
the
do-not-merge/work-in-progress
vladimirvivien
changed the title
klient.ClientEnvironment to support new typeklient.Client
k8s-ci-robot
added
size/XL
vladimirvivien
changed the title
Environment to support new typeklient.ClientEnvironment and env Config to support new typeklient.Client
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
cpanato
reviewed
Jul 16, 2021
cpanato
reviewed
Jul 16, 2021
| } | ||
|
|
||
| func randNS() string { | ||
| bytes := make([]byte, 25) |
There was a problem hiding this comment.
maybe we can use github.com/google/uuid and generate an uuid and remove the testns-%s.
just an idea :)
There was a problem hiding this comment.
@cpanato thanks. I will checkout the google project.
Also, I added the "test" so that if, for whatever reasons, a namespace lingers, you will be able to easily identify it.
There was a problem hiding this comment.
make sense, as i said just a suggestion :)
…lient This PR refactors type env.Environment and envconf.Config to support new type klient.Client. Thype klient.Client makes easy to access the functionalities of the klient package from one type withouth having to create several steps. Signed-off-by: Vladimir Vivien <vivienv@vmware.com>
vladimirvivien
force-pushed
the
klient-Client-type
branch
from
b394c9f
to
15c3022
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is needed to refactor the way type
Environmentis constructed and initialized with packageklientwhich did not exist when this package was created. This work is also a precursor to the refactoring work that will take place to fix context propagation.This potentially will address
Context propagation will be handled in a future PR