Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom labels and annotations for namespace creation #382

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Allow custom labels and annotations for namespace creation #382

merged 5 commits into from
Feb 19, 2024

Conversation

Fricounet
Copy link
Contributor

@Fricounet Fricounet commented Feb 15, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Create 2 new option functions that can be used when calling CreateNamespace to add custom labels and annotations to the namespace.

Which issue(s) this PR fixes:

Fixes #364

Special notes for your reviewer:

I also added tests to make sure the function work as expected (this is how I discovered #381), however it looks like there is no automated testing in place. In the meantime, tests can be run with go test ./pkg/envfuncs.

To be merged after #381

Does this PR introduce a user-facing change?

Added a way to create namespaces with custom labels and annotations

Additional documentation e.g., Usage docs, etc.:

@Fricounet
[envfuncs] Fix DeleteNamespace retrieving ns from ctx
c339764 
The function DeleteNamespace was not succeeding in retrieving the
namespace from the context because it tried to cast a corev1.Namespace
to *corev1.Namespace.
@Fricounet
[envfuncs] Allow custom labels and annotations for namespace creation
05a2f32 
Create 2 new option functions that can be used when calling
`CreateNamespace` to add custom labels and annotations to the namespace.
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 15, 2024
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Feb 15, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Fricounet. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 15, 2024
cpanato
cpanato reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2024
@Fricounet Fricounet force-pushed the fricounet/namespace-labels-annotations branch from 7bb0bd9 to de358a2 Compare February 15, 2024 14:47
@Fricounet Fricounet force-pushed the fricounet/namespace-labels-annotations branch from de358a2 to d50672d Compare February 15, 2024 14:54
vladimirvivien
vladimirvivien reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@vladimirvivien vladimirvivien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Fricounet
This looks great to me.
@harshanarayana PTAL, if you are OK, please approve.

@vladimirvivien
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2024
@Fricounet Fricounet mentioned this pull request Feb 16, 2024
Merged
@Fricounet Fricounet force-pushed the fricounet/namespace-labels-annotations branch from 9f3b76f to 818fe59 Compare February 16, 2024 22:20
@Fricounet
Copy link
Contributor Author

/retest

harshanarayana
harshanarayana approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@harshanarayana harshanarayana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fricounet, harshanarayana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5a3820e into kubernetes-sigs:main Feb 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirvivien vladimirvivien vladimirvivien left review comments

@cpanato cpanato cpanato left review comments

@harshanarayana harshanarayana harshanarayana approved these changes

@ShwethaKumbla ShwethaKumbla Awaiting requested review from ShwethaKumbla

Assignees

@vladimirvivien vladimirvivien

@harshanarayana harshanarayana

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow adding custom labels and annotations when creating namespace
5 participants
@Fricounet @k8s-ci-robot @vladimirvivien @harshanarayana @cpanato