Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable feature flag to reverse test finish action #389

Conversation

harshanarayana
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Changes in this PR enable the consumers of e2e-framework to set a feature flag that enables the execution of Finish actions to mimic the nature of t.Cleanup.

Which issue(s) this PR fixes:

Fixes #269

Special notes for your reviewer:

NA

Does this PR introduce a user-facing change?

added a feature-gate argument to the supported flags that will enable setting `ReverseTestFinishExecutionOrder` so that `Finish` action can mimic `t.Cleanup`

Additional documentation e.g., Usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 5, 2024
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Mar 5, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 5, 2024
@harshanarayana harshanarayana force-pushed the feature/git-269/enable-test-finish-in-reverse-order branch from 1184018 to 40392ce Compare March 5, 2024 07:06
@harshanarayana harshanarayana force-pushed the feature/git-269/enable-test-finish-in-reverse-order branch from 40392ce to d459eec Compare March 5, 2024 09:36
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, harshanarayana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b38d517 into kubernetes-sigs:main Mar 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execute "testenv.Finish" steps in a reverse order
3 participants