initialize k8s client access appropriately when a cluster exists #406
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
sig/testing
k8s-ci-robot
added
the
size/XS
|
/retest |
k8s-ci-robot
added
the
lgtm
|
@sanposhiho thanks for the PR.. Seems like the same bug exists in the |
sanposhiho
force-pushed
the
existing-client
branch
from
b8304ad
to
6f7954c
Compare
k8s-ci-robot
added
size/S
|
@harshanarayana Done. |
|
Thanks very much @sanposhiho |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sanposhiho, vladimirvivien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
ssia.
Currently, when a cluster already exists,
initKubernetesAccessClientswon't be run.initKubernetesAccessClientsis mandatory to be run to make*clusterreturnKubernetesRestConfig, and consequently nowKubernetesRestConfigalways results innilin such case.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., Usage docs, etc.: