support skipping tests by labels, assessment and feature name #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
|
/retest |
ShwethaKumbla
force-pushed
the
skip-label
branch
2 times, most recently
from
74ef030
to
a135fa9
Compare
ShwethaKumbla
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
ShwethaKumbla
force-pushed
the
skip-label
branch
from
a135fa9
to
2fb2dfa
Compare
|
/cc @vladimirvivien |
There was a problem hiding this comment.
This looks awesome @ShwethaKumbla
Please update the ./examples to actually use the skip functionality as additional test.
ShwethaKumbla
force-pushed
the
skip-label
branch
from
2fb2dfa
to
fea87ff
Compare
|
/test pull-e2e-framework-test |
k8s-ci-robot
added
the
needs-rebase
ShwethaKumbla
force-pushed
the
skip-label
branch
from
fea87ff
to
a2c504b
Compare
k8s-ci-robot
removed
the
needs-rebase
ShwethaKumbla
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
ShwethaKumbla
force-pushed
the
skip-label
branch
3 times, most recently
from
f275d6e
to
0c6ade9
Compare
k8s-ci-robot
added
the
needs-rebase
ShwethaKumbla
force-pushed
the
skip-label
branch
from
0c6ade9
to
e4ec298
Compare
k8s-ci-robot
removed
the
needs-rebase
ShwethaKumbla
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-e2e-framework-test |
2 similar comments
|
/test pull-e2e-framework-test |
|
/test pull-e2e-framework-test |
vladimirvivien
approved these changes
Oct 13, 2021
| @@ -80,3 +80,21 @@ func TestWithFlags(t *testing.T) { | |||
|
|
|||
| test.Test(t, f.Feature()) | |||
| } | |||
|
|
|||
| func TestWithSkipFlags(t *testing.T) { | |||
There was a problem hiding this comment.
Since you have examples/skip_flags you could omit this test.
Your call.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ShwethaKumbla, vladimirvivien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces --skip-labels and --skip-features flags for tests.
Fix for : #25