Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to the root README file #53

Merged
merged 1 commit into from Sep 17, 2021
Merged

Update to the root README file #53

merged 1 commit into from Sep 17, 2021

Conversation

vladimirvivien
Copy link
Contributor

  • Clarify the language describing the project
  • Also added small code snippet of example

@vladimirvivien
Update to the README file
feaffc8 
Clarify the language on the README file.
Also added small snippet of example.

Signed-off-by: Vladimir Vivien <vivienv@vmware.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 15, 2021
@vladimirvivien
Copy link
Contributor Author

/assign @cpanato

@vladimirvivien
Copy link
Contributor Author

@cpanato @ShwethaKumbla PTAL

cpanato
cpanato approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5ae5375 into kubernetes-sigs:main Sep 17, 2021
@vladimirvivien vladimirvivien deleted the readme-update branch June 23, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vladimirvivien @k8s-ci-robot @cpanato