Skip to content

Commit

Permalink
Exclude etcd-manager from the style checks for the moment
Browse files Browse the repository at this point in the history
We can then merge the repos and fix the problems here.
  • Loading branch information
justinsb committed Aug 29, 2020
1 parent 3aba373 commit c184acb
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions hack/verify-golint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ go build -o ./golint/golint ./golint
# run the binary
cd "${REPO_PATH}"
echo "Running golint..."
# To ease merging repos, we initially exclude etcd-manager, then will fix it here
git ls-files | grep "\.go" | \
grep -v "vendor\/" | \
grep -v "etcd-manager\/" | \
xargs -L1 "${TMP_DIR}/golint/golint" -set_exit_status
3 changes: 2 additions & 1 deletion hack/verify-govet.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ cd_root_path
# run go vet
export GO111MODULE=on
ERROR=0
DIRS=$(git ls-files | grep -v "vendor\/" | grep ".go" | xargs dirname | grep -v "\." | cut -d '/' -f 1 | uniq)
# To ease merging repos, we initially exclude etcd-manager, then will fix it here
DIRS=$(git ls-files | grep -v "vendor\/" | grep -v "etcd-manager\/" | grep ".go" | xargs dirname | grep -v "\." | cut -d '/' -f 1 | uniq)
while read -r dir; do
go vet ./"$dir"/... || ERROR=1
done <<< "$DIRS"
Expand Down
3 changes: 2 additions & 1 deletion hack/verify-whitespace.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ if [[ ! -z "$TRAILING" ]]; then
fi

echo -e "Verifying new lines at end of files..."
FILES="$(git ls-files | grep -I -v -e "vendor\/" -v -e "\.svg")"
# To ease merging repos, we initially exclude etcd-manager, then will fix it here
FILES="$(git ls-files | grep -I -v -e "vendor\/" -v -e "etcd-manager\/" -v -e "\.svg")"
while read -r LINE; do
grep -qI . "${LINE}" || continue # skip binary files
c="$(tail -c 1 "${LINE}")"
Expand Down

0 comments on commit c184acb

Please sign in to comment.