Skip to content

Commit

Permalink
Decrease log level for AWS provider when no changes required
Browse files Browse the repository at this point in the history
There are many messages, that do not provide usefull information:

```
time="2020-05-12T10:55:09Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones"
time="2020-05-12T10:56:10Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones"
time="2020-05-12T10:57:10Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones"
time="2020-05-12T10:58:10Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones"
time="2020-05-12T10:59:09Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones"
time="2020-05-12T11:00:10Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones"
time="2020-05-12T11:01:09Z" level=info msg="All records are already up to date, there are no changes for the matching hosted zones"
```

It would help to remove this noise to DEBUG level.
  • Loading branch information
Michael Nikitochkin committed May 12, 2020
1 parent 2ef1503 commit 62f4fa5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions provider/aws/aws.go
Original file line number Diff line number Diff line change
Expand Up @@ -400,14 +400,14 @@ func (p *AWSProvider) ApplyChanges(ctx context.Context, changes *plan.Changes) e
func (p *AWSProvider) submitChanges(ctx context.Context, changes []*route53.Change, zones map[string]*route53.HostedZone) error {
// return early if there is nothing to change
if len(changes) == 0 {
log.Info("All records are already up to date")
log.Debug("All records are already up to date")
return nil
}

// separate into per-zone change sets to be passed to the API.
changesByZone := changesByZone(zones, changes)
if len(changesByZone) == 0 {
log.Info("All records are already up to date, there are no changes for the matching hosted zones")
log.Debug("All records are already up to date, there are no changes for the matching hosted zones")
}

var failedZones []string
Expand Down

0 comments on commit 62f4fa5

Please sign in to comment.