Skip to content

Commit

Permalink
Update CRD source doc with RBAC, fix CRD manifest
Browse files Browse the repository at this point in the history
* Add RBAC piece of documentation

* Remove `status:` to avoid validation failure

Otherwise it fails with
```
$ kubectl apply -f crd-manifest.yaml
error: error validating "crd-manifest.yaml": error validating data: ValidationError(CustomResourceDefinition.status): missing required field "storedVersions" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1beta1.CustomResourceDefinitionStatus;
```
  • Loading branch information
ytsarev committed Dec 28, 2019
1 parent e68ea60 commit 9562443
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 5 deletions.
12 changes: 12 additions & 0 deletions docs/contributing/crd-source.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,3 +106,15 @@ INFO[0000] Connected to cluster at https://192.168.99.100:8443
INFO[0000] CREATE: foo.bar.com 180 IN A 192.168.99.216
INFO[0000] CREATE: foo.bar.com 0 IN TXT "heritage=external-dns,external-dns/owner=default"
```

### RBAC configuration

If you use RBAC, extend the `external-dns` ClusterRole with:
```
- apiGroups: ["externaldns.k8s.io"]
resources: ["dnsendpoints"]
verbs: ["get","watch","list"]
- apiGroups: ["externaldns.k8s.io"]
resources: ["dnsendpoints/status"]
verbs: ["*"]
```
5 changes: 0 additions & 5 deletions docs/contributing/crd-source/crd-manifest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,3 @@ spec:
type: integer
type: object
version: v1alpha1
status:
acceptedNames:
kind: ""
plural: ""
conditions: null

0 comments on commit 9562443

Please sign in to comment.