Fix Istio Ingress Gateway Service setting

kubernetes-sigs · May 15, 2020 · a4914aa · a4914aa
1 parent 2ef1503
commit a4914aa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/pkg/apis/externaldns/types.go b/pkg/apis/externaldns/types.go
@@ -288,6 +288,9 @@ func (cfg *Config) ParseFlags(args []string) error {
 	app.Flag("cf-username", "The username to log into the cloud foundry API").Default(defaultConfig.CFUsername).StringVar(&cfg.CFUsername)
 	app.Flag("cf-password", "The password to log into the cloud foundry API").Default(defaultConfig.CFPassword).StringVar(&cfg.CFPassword)
 
+	// Istio IngressGateway
+	app.Flag("istio-ingress-gateway", "The Istio Ingress gateway (default: istio-system/istio-ingressgateway)").Default("istio-system/istio-ingressgateway").StringsVar(&cfg.IstioIngressGatewayServices)
+
 	// Flags related to Contour
 	app.Flag("contour-load-balancer", "The fully-qualified name of the Contour load balancer service. (default: heptio-contour/contour)").Default("heptio-contour/contour").StringVar(&cfg.ContourLoadBalancerService)
 

diff --git a/pkg/apis/externaldns/types_test.go b/pkg/apis/externaldns/types_test.go
@@ -98,6 +98,7 @@ var (
 		RcodezeroTXTEncrypt:         false,
 		TransIPAccountName:          "",
 		TransIPPrivateKeyFile:       "",
+		IstioIngressGatewayServices: []string{"istio-system/istio-ingressgateway"},
 	}
 
 	overriddenConfig = &Config{
@@ -177,6 +178,7 @@ var (
 		NS1IgnoreSSL:                true,
 		TransIPAccountName:          "transip",
 		TransIPPrivateKeyFile:       "/path/to/transip.key",
+		IstioIngressGatewayServices: []string{"istio-system/my-istio-ingressgateway"},
 	}
 )
 
@@ -207,6 +209,7 @@ func TestParseFlags(t *testing.T) {
 				"--source=service",
 				"--source=ingress",
 				"--source=connector",
+				"--istio-ingress-gateway=istio-system/my-istio-ingressgateway",
 				"--namespace=namespace",
 				"--fqdn-template={{.Name}}.service.example.com",
 				"--ignore-hostname-annotation",
@@ -364,6 +367,7 @@ func TestParseFlags(t *testing.T) {
 				"EXTERNAL_DNS_NS1_IGNORESSL":                   "1",
 				"EXTERNAL_DNS_TRANSIP_ACCOUNT":                 "transip",
 				"EXTERNAL_DNS_TRANSIP_KEYFILE":                 "/path/to/transip.key",
+				"EXTERNAL_DNS_ISTIO_INGRESS_GATEWAY":           "istio-system/my-istio-ingressgateway",
 			},
 			expected: overriddenConfig,
 		},