Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DigitalOcean API 503 response causes thousands of duplicate domain records to be created #503

Closed
Noah-Huppert opened this issue Mar 17, 2018 · 1 comment

Comments

@Noah-Huppert
Copy link

I went to check on my DNS records today and found that my domain now has ~3000 DNS entries. Meaning that external-dns created about 1500 A records for the same ingress.

Looking at the external-dns pod I see many many lines with the following message:

time="2018-03-16T23:46:03Z" level=info msg="Changing record." action=CREATE record=www.noahhuppert.com type=TXT zone=noahhuppert.com

With this error occasionally showing up:

time="2018-03-16T17:45:58Z" level=error msg="GET https://api.digitalocean.com/v2/domains: 503 Service is currently unavailable."

I suspect that the external-dns DigitalOcean controler does not handle bad API responses correctly. However I couldn't be sure.

external-dns pod logs

@mikkeloscar
Copy link
Contributor

See #501

@Raffo Raffo closed this as completed in #501 Apr 4, 2018
lou-lan pushed a commit to lou-lan/external-dns that referenced this issue May 11, 2022
Install is much more likely to fail than storing the receipt.
Before, when the install failed, the new receipts was already
written to disk and not rolled back. Now, the receipt is only
stored when install has succeeded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants