Add VinylDNS as a provider #1080
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
dgrizzanti
force-pushed
the
vinyldns_provider
branch
from
16db9c4
to
154f17f
Compare
dgrizzanti
force-pushed
the
vinyldns_provider
branch
from
057897c
to
5b28d7f
Compare
| nginx 10.0.0.115 34.x.x.x 80:30543/TCP 2m | ||
| ``` | ||
|
|
||
| ## Running a locally built version pointed to the above nginx service |
There was a problem hiding this comment.
Can you also add some notes how to deploy it, see https://github.com/kubernetes-incubator/external-dns/blob/master/docs/tutorials/cloudflare.md#deploy-externaldns?
README.md
Outdated
| @@ -43,7 +43,7 @@ ExternalDNS' current release is `v0.5`. This version allows you to keep selected | |||
| * [RFC2136](https://tools.ietf.org/html/rfc2136) | |||
| * [NS1](https://ns1.com/) | |||
| * [TransIP](https://www.transip.eu/domain-name/) | |||
|
|
|||
| * [VinylDNS](hhttps://www.vinyldns.io) | |||
main.go
Outdated
| @@ -133,6 +132,8 @@ func main() { | |||
| p, err = provider.NewAWSSDProvider(domainFilter, cfg.AWSZoneType, cfg.AWSAssumeRole, cfg.DryRun) | |||
| case "azure": | |||
| p, err = provider.NewAzureProvider(cfg.AzureConfigFile, domainFilter, zoneIDFilter, cfg.AzureResourceGroup, cfg.DryRun) | |||
| case "vinyldns": | |||
| p, err = provider.NewVinylDNSProvider(zoneIDFilter, cfg.DryRun) | |||
There was a problem hiding this comment.
Any chances of adding domainFilter to filter?
provider/vinyldns.go
Outdated
| // Adding a . as vinyl appends it to each zone record | ||
| if strings.HasSuffix(hostname+".", z.Name) { | ||
| if zone == nil || len(z.Name) > len(zone.Name) { | ||
| newZ := z |
There was a problem hiding this comment.
maybe and don't see it correct but why not directly assigning it to zone?
|
@njuettner thanks for the comments - PR should be updated! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
VinylDNS is a vendor agnostic front-end for enabling self-service DNS and streamlining DNS operations. It is designed to integrate with your existing DNS infrastructure, and provides extensibility to fit your installation.
This PR provides basic functionality for integration with VinylDNS for A, CNAME, and TXT records for use with external-dns.
As I am submitting this PR, I am happy to be a maintainer on this provider.