Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for human-friendly TTL values #1237

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Add support for human-friendly TTL values #1237

merged 1 commit into from
Feb 4, 2020

Conversation

hypnoglow
Copy link
Contributor

Add support for specifying TTL values in Golang duration format for
external-dns.alpha.kubernetes.io/ttl annotation.

Fixes #1183

@k8s-ci-robot
Copy link
Contributor

Welcome @hypnoglow!

It looks like this is your first PR to kubernetes-incubator/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 24, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 24, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 24, 2019
@hypnoglow
Copy link
Contributor Author

/assign @Raffo

njuettner
njuettner reviewed Oct 29, 2019
View reviewed changes
docs/ttl.md Outdated Show resolved Hide resolved
njuettner
njuettner reviewed Oct 29, 2019
View reviewed changes
source/source.go Outdated Show resolved Hide resolved
njuettner
njuettner requested changes Oct 29, 2019
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍. I added two comments, PTAL.

@hypnoglow
Copy link
Contributor Author

Rebased as it was a bit stale

@njuettner
Copy link
Member

@hypnoglow Can you please check linting again

source/source_test.go:71: File is not `goimports`-ed (goimports)
			title: "TTL annotation value is set correctly using duration (whole)",
Makefile:34: recipe for target 'lint' failed

@hypnoglow
Add support for human-friendly TTL values
6e6af8a 
Supports specifying TTL values in Golang duration format for
`external-dns.alpha.kubernetes.io/ttl` annotation.
@hypnoglow
Copy link
Contributor Author

@njuettner Should be fixed now, thanks for the remark.

@njuettner
Copy link
Member

@hypnoglow sorry for my late response, what happens when people still use the old annotation, will this break things when releasing this PR in the next release? I want to avoid this TBH.

@hypnoglow
Copy link
Contributor Author

@hypnoglow sorry for my late response, what happens when people still use the old annotation, will this break things when releasing this PR in the next release? I want to avoid this TBH.

Old behaviour is preserved, annotations with integer values representing seconds should still work, tests still cover it.

njuettner
njuettner approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hypnoglow, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 829ed01 into kubernetes-sigs:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@hjacobs hjacobs Awaiting requested review from hjacobs

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support human ttl values like 10m
4 participants
@hypnoglow @k8s-ci-robot @njuettner @Raffo