Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked tutorial for Azure Private DNS #1319

Conversation

saidst
Copy link
Contributor

@saidst saidst commented Dec 12, 2019

First use showed the tutorial for Azure DNS & Azure Private DNS to be not practically usable for all users.
In particular, it required some special knowledge about the required configuration of the employeed nginx-ingress-controller.

This PR refines the tutorial to make endusers be able to work through it completely.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2019
@saidst saidst changed the title WIP: Reworked tutorial for azure private dns WIP: Reworked tutorial for Azure Private DNS Dec 12, 2019
@saidst
Copy link
Contributor Author

saidst commented Dec 13, 2019

FYI @timja

Copy link
Contributor

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I don’t remember having to do this but I tested it on minikube, it’s probably on by default there.

I’ve had to enable this when using traefik before

@dstampfli
Copy link

This looks good to me as well. Sorry for the slow response and thanks for doing the update. This is mentioned in the tutorial but I wanted to point out explicitly that when controller.publishService.enabled=true is set on the ingress controller a describe of the ingress resource will show the IP of the load balancer in the address column as shown below. This does not happen (field is blank) is that parameter is not set.

NAME   HOSTS                             ADDRESS             PORTS   AGE
nginx1   sample1.aksdemos.com   52.167.189.120   80      6d22h
nginx2   sample2.aksdemos.com   52.167.189.120   80      6d21h

@saidst
Copy link
Contributor Author

saidst commented Dec 17, 2019

Would you recommend...

  1. to describe the observations one can make in case the parameter is not set properly?
  2. to contain a sample output of the describe command when the parameter has been set correctly?

I tend to go for 2).

@dstampfli
Copy link

Agree that #2 is best.

@saidst saidst force-pushed the feature/extend-azure-private-dns-tutorial branch from 493935c to c665761 Compare December 17, 2019 18:46
@saidst
Copy link
Contributor Author

saidst commented Dec 17, 2019

Thanks Dave. Updated the doc accordingly.

@saidst
Copy link
Contributor Author

saidst commented Dec 17, 2019

Also thanks @timja for checking this out. I remove WIP now.

@saidst saidst changed the title WIP: Reworked tutorial for Azure Private DNS Reworked tutorial for Azure Private DNS Dec 17, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2019
@saidst
Copy link
Contributor Author

saidst commented Dec 17, 2019

/assign @njuettner

Would you help again by reviewing and merging?

Thanks.

Copy link
Contributor

@Raffo Raffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saidst I just have one trivial suggestion, the other parts are good to go. Ping me once you fixed that and we can merge it.

docs/tutorials/azure-private-dns.md Outdated Show resolved Hide resolved
@Raffo Raffo assigned Raffo and unassigned njuettner Dec 19, 2019
@Raffo
Copy link
Contributor

Raffo commented Dec 20, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, saidst

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit e68ea60 into kubernetes-sigs:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants